-
Notifications
You must be signed in to change notification settings - Fork 5.1k
chore: zod 4 #38809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: zod 4 #38809
Changes from all commits
40216b4
820b4ec
a8fa479
d080865
bb5b8d2
bb6c2c5
f19c25a
957623e
aea6fb8
a063d44
5b1696b
4f3d02d
f9197e6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,7 +58,7 @@ export class BrowserServerBackend implements ServerBackend { | |
| const tool = this._tools.find(tool => tool.schema.name === name)!; | ||
| if (!tool) | ||
| throw new Error(`Tool "${name}" not found`); | ||
| const parsedArguments = tool.schema.inputSchema.parse(rawArguments || {}); | ||
| const parsedArguments = tool.schema.inputSchema.parse(rawArguments || {}) as any; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need this?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this used to be any, now it's |
||
| const context = this._context!; | ||
| const response = new Response(context, name, parsedArguments); | ||
| response.logBegin(); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please measure the bundle compilation time and the output size (e.g.
ls -lh packages/playwright-core/lib/mcpBundleImpl/index.js) with old/new version. Rolling sdk and zod withoutanyhack for sdk would leave in a bad state (see modelcontextprotocol/typescript-sdk#1313), let's make sure this doesn't regress because of the zod.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old
886k
new
666K
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The size is shrinking, yay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did something wrong when measuring. it now shows 411K on main, so the size actually grew