Skip to content

Conversation

@manuel-delverme
Copy link
Contributor

Copy-paste error?

assigns element.scrollTop to scrollLeft property. This will cause horizontal scroll positions to be restored incorrectly in snapshot rendering.

Copy-paste error: assigns element.scrollTop to scrollLeft property. This will cause horizontal scroll positions to be restored incorrectly in snapshot rendering.

Signed-off-by: Manuel <manuel.delverme@gmail.com>
Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/planner.spec.ts:69 › planner_setup_page seed resolution @mcp-macos-15
❌ [chrome] › mcp/planner.spec.ts:131 › planner_setup_page with dependencies @mcp-macos-15

2828 passed, 121 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

30 failed
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node22
❌ [firefox-library] › library/agent-expect.spec.ts:223 › expectURL success @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:261 › expectURL with regex @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @firefox-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:223 › expectURL success @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:261 › expectURL with regex @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @webkit-ubuntu-22.04-node20
❌ [playwright-test] › playwright.artifacts.spec.ts:127 › should work with screenshot: on @macos-latest-node20
❌ [playwright-test] › playwright.spec.ts:877 › page.pause() should disable test timeout @macos-latest-node20
❌ [playwright-test] › reporter-html.spec.ts:333 › merged › should include screenshot on failure @macos-latest-node20
❌ [playwright-test] › ui-mode-trace.spec.ts:426 › should work behind reverse proxy @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:299 › should update missing snapshots in tsx @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:669 › update-source-method › should overwrite source when specified in the config @macos-latest-node20

6 flaky ⚠️ [chromium-library] › library/browsertype-connect.spec.ts:935 › run-server › socks proxy › should proxy based on the pattern `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35 › should update locator highlight `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsercontext-add-cookies.spec.ts:426 › should allow unnamed cookies `@webkit-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:645 › run-server › should record trace with sources `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:688 › should indicate current test status `@macos-latest-node20`

34567 passed, 691 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants