-
Notifications
You must be signed in to change notification settings - Fork 5k
fix: H-scroll positions after restore #38822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Copy-paste error: assigns element.scrollTop to scrollLeft property. This will cause horizontal scroll positions to be restored incorrectly in snapshot rendering. Signed-off-by: Manuel <manuel.delverme@gmail.com>
Skn0tt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, seems like a copy-paste error: https://github.com/microsoft/playwright/pull/33809/changes#diff-3448de0c4b59dc4cbf5203b6737dc9769601e0e638ce29e05b579ae1bb764ea0R386
Thanks!
Test results for "MCP"2 failed 2828 passed, 121 skipped Merge workflow run. |
Test results for "tests 1"30 failed 6 flaky34567 passed, 691 skipped Merge workflow run. |
Copy-paste error?
assigns element.scrollTop to scrollLeft property. This will cause horizontal scroll positions to be restored incorrectly in snapshot rendering.