Skip to content

Conversation

@pavelfeldman
Copy link
Member

No description provided.

if (os.platform() === 'linux') {
const runningAsRoot = process.geteuid && process.geteuid() === 0;
if (runningAsRoot && electronArguments.indexOf('--no-sandbox') === -1)
if (!options.chromiumSandbox && electronArguments.indexOf('--no-sandbox') === -1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't it spam into the terminal now if running not as root?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running as non-root it won't use sandbox. I don't think it spams.

@github-actions
Copy link
Contributor

Test results for "MCP"

5 failed
❌ [webkit] › mcp/cli.spec.ts:483 › config › should work @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:426 › session › session-stop named session @mcp-windows-latest
❌ [chrome] › mcp/video.spec.ts:23 › should work with --save-video (persistent) @mcp-macos-15
❌ [chromium] › mcp/core.spec.ts:158 › browser_resize @mcp-macos-15
❌ [chromium] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15

3441 passed, 116 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

10 failed
❌ [playwright-test] › reporter-junit.spec.ts:310 › created › should render existing attachments, but not missing ones @macos-latest-node20
❌ [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout @macos-latest-node20
❌ [playwright-test] › test-parallel.spec.ts:227 › parallel mode should display worker count taking project workers into account @macos-latest-node20
❌ [playwright-test] › test-step.spec.ts:1463 › reading network request / response should not be listed as step @macos-latest-node20
❌ [playwright-test] › to-have-screenshot.spec.ts:907 › should use provided name @macos-latest-node20
❌ [playwright-test] › to-have-screenshot.spec.ts:923 › should use provided name via options @macos-latest-node20
❌ [playwright-test] › to-have-screenshot.spec.ts:939 › should respect maxDiffPixels option @macos-latest-node20
❌ [playwright-test] › to-have-screenshot.spec.ts:1022 › should satisfy both maxDiffPixelRatio and maxDiffPixels @macos-latest-node20
❌ [playwright-test] › to-have-screenshot.spec.ts:1091 › should respect maxDiffPixelRatio option @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:461 › should update when options are specified @macos-latest-node20

7 flaky ⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35 › should update locator highlight `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-test-run.spec.ts:195 › should run by project `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145 › should watch all `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:434 › should work behind reverse proxy `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:701 › should indicate current test status `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:155 › should watch test `@ubuntu-latest-node24`

34181 passed, 668 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants