Skip to content

fix(trace viewer): make paths via stdin work #39121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Skn0tt merged 1 commit into from
Feb 5, 2026
Merged

fix(trace viewer): make paths via stdin work #39121

Skn0tt merged 1 commit into from
Feb 5, 2026
+19 −6

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Feb 4, 2026

Closes #39096, which is a regression from #38566. The fix is exactly what @li-zhixin outlines, thanks!

@Skn0tt Skn0tt self-assigned this Feb 4, 2026
Skn0tt
Skn0tt commented Feb 4, 2026
View reviewed changes
packages/playwright-core/src/server/trace/viewer/traceViewer.ts Outdated
host?: string;
port?: number;
isServer?: boolean;
stdin?: Readable;
Copy link
Member Author

@Skn0tt Skn0tt Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be imported via playwright-core/server. I suspect we only have it for testing purposes, and it's not part of our public API to anyone.

@li-zhixin li-zhixin mentioned this pull request Feb 4, 2026
Closed
2 tasks
@github-actions

This comment has been minimized.

Sign in to view
@Skn0tt Skn0tt force-pushed the fix-trace-viewer-format branch from f3d48f9 to d5a793c Compare February 4, 2026 09:10
@Skn0tt Skn0tt requested a review from dgozman February 4, 2026 09:11
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@dgozman dgozman requested a review from pavelfeldman February 4, 2026 14:24
pavelfeldman
pavelfeldman reviewed Feb 4, 2026
View reviewed changes
@Skn0tt Skn0tt force-pushed the fix-trace-viewer-format branch from d5a793c to d014f93 Compare February 5, 2026 10:19
@github-actions

This comment has been minimized.

Sign in to view
dgozman
dgozman approved these changes Feb 5, 2026
View reviewed changes
tests/config/traceViewerFixtures.ts Outdated
});
},

startTraceViewer: async ({ context, childProcess }, use) => {
Copy link
Contributor

@dgozman dgozman Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is hard! I will not be able to figure whether to startTraceViewer or showTraceViewer later on. Perhaps inline this fixture into the test for now?

@github-actions

This comment has been minimized.

Sign in to view
@Skn0tt
fix(trace viewer): make paths via stdin work
5fe219f 
Co-authored-by: li-zhixin <cruz.liu@developertools.com>
@Skn0tt Skn0tt force-pushed the fix-trace-viewer-format branch from d014f93 to 5fe219f Compare February 5, 2026 14:58
@Skn0tt Skn0tt merged commit 429a39b into microsoft:main Feb 5, 2026
30 of 32 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Test results for "tests 1"

4 failed
❌ [playwright-test] › playwright.trace.spec.ts:137 › should not throw with trace: on-first-retry and two retries in the same worker @macos-latest-node20
❌ [playwright-test] › to-have-screenshot.spec.ts:1022 › should satisfy both maxDiffPixelRatio and maxDiffPixels @macos-latest-node20
❌ [playwright-test] › ui-mode-test-output.spec.ts:80 › should show console messages for test @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:669 › update-source-method › should overwrite source when specified in the config @macos-latest-node20

6 flaky ⚠️ [chromium-page] › page/page-event-console.spec.ts:250 › should have timestamp in consoleMessages `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-page] › page/page-event-console.spec.ts:250 › should have timestamp in consoleMessages `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:38 › should upload a folder `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:185 › should show snapshots for steps `@macos-latest-node20`

34215 passed, 756 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Test results for "MCP"

4649 passed, 135 skipped

Merge workflow run.

dgozman pushed a commit that referenced this pull request Feb 5, 2026
@Skn0tt @dgozman
cherry-pick(#39121): fix(trace viewer): make paths via stdin work
8684e08 
Co-authored-by: li-zhixin <cruz.liu@developertools.com>
@Skn0tt Skn0tt mentioned this pull request Feb 6, 2026
Merged
@github-actions github-actions bot mentioned this pull request Feb 7, 2026
Closed
Copilot AI mentioned this pull request Feb 7, 2026
Closed
This was referenced Feb 10, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman left review comments

@dgozman dgozman dgozman approved these changes

Assignees

@Skn0tt Skn0tt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(trace): StdinServer._loadTrace does not convert file path to URI format

3 participants

@Skn0tt @pavelfeldman @dgozman