api(video): simplify video api #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
approved these changes
Sep 18, 2020
yury-s
approved these changes
Sep 18, 2020
| if (pageOrError instanceof Page) | ||
| makeWaitForNextTask()(() => pageOrError.emit(Page.Events.VideoStarted, video)); |
There was a problem hiding this comment.
This was necessary for the following code to work:
const page = await context.newPage();
const v = await page.waitForEvent('videostarted');Do we not need this to work any more?
There was a problem hiding this comment.
Yeah, we don't have an event anymore, so this is not a problem currently.
This leaves just `recordVideos` and `videoSize` options on the context. Videos are saved to `artifactsPath`. We also save their ids to trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recordVideosandvideoSizeoptions on the context.artifactsPath. We also save their file names to trace.context.close()waits for the processed videos.