test: migrate some helpers to fixtures, use testOutputDir #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Sep 18, 2020
- Save various test artifacts to testOutputDir instead of tmpDir.
For example, download tests put downloaded files to
`test-results/download/should_work/download.txt` and could be
examined after test run.
- Make `expectedSSLError` a fixture that depends on platform and browserName.
- Turn `{make,remove}UserDataDir` into `createUserDataDir` fixture.
- Move `attachFrame`, `detachFrame` and `verifyViewport` helpers.
- Remove `registerEngine` helper because worker isolation solves it.
- Remove `test/utils.js`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save various test artifacts to testOutputDir instead of tmpDir.
For example, download tests put downloaded files to
test-results/download/should_work/download.txtthat can beexamined after test run.
Make
expectedSSLErrora fixture that depends on platform and browserName.Turn
{make,remove}UserDataDirintocreateUserDataDirfixture.Move
attachFrame,detachFrameandverifyViewporthelpers.Remove
registerEnginehelper because worker isolation solves it.Remove
test/utils.js.