browser(firefox): remove multisession logic #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: 1. Changes `SimpleChannel` to buffer messages to the namespace that hasn't been registered yet. This allows us to create `SimpleChannel` per target on the browser side right away. 2. Removes multisession support. Now there's only one `PageAgent` in the content process, which talks to a single `PageHandler` on the browser side. Both ends can be created as-soon-as-needed; thanks to `SimpleChannel` bufferring, no messages will be lost and all messages will be delivered in proper order. (This is currently the reason why build 1178 flakes on windows). 3. Straightens up the target reporting. Targets are reported as soon as they appear on the browser side. References microsoft#3995
aslushnikov
commented
Oct 2, 2020
| @@ -70,6 +71,14 @@ class SimpleChannel { | |||
| if (this._handlers.has(namespace)) | |||
| throw new Error('ERROR: double-register for namespace ' + namespace); | |||
| this._handlers.set(namespace, handler); | |||
| // Try to re-deliver all pending messages. | |||
| Promise.resolve().then(() => { | |||
There was a problem hiding this comment.
do an explicit method instead: ready!
aslushnikov
commented
Oct 2, 2020
| @@ -128,8 +127,10 @@ class BrowserHandler { | |||
| } | |||
|
|
|||
| async newPage({browserContextId}) { | |||
| const targetId = await this._targetRegistry.newPage({browserContextId}); | |||
| return {targetId}; | |||
| const target = await this._targetRegistry.newPage({browserContextId}); | |||
There was a problem hiding this comment.
revert this back
aslushnikov
commented
Oct 2, 2020
| disconnectSession(session) { | ||
| if (!this._disposed) | ||
| this._channel.connect('').emit('detach', { sessionId: session.sessionId() }); | ||
| async disconnectSession(session) { |
There was a problem hiding this comment.
kill disconnect
dgozman
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
SimpleChannelto buffer messages to the namespace thathasn't been registered yet. This allows us to create
SimpleChannelper target on the browser side right away.
PageAgentin thecontent process, which talks to a single
PageHandleron the browserside. Both ends can be created as-soon-as-needed; thanks to
SimpleChannelbufferring, no messages will be lost and all messageswill be delivered in proper order. (This is currently the reason why
build 1178 flakes on windows).
as they appear on the browser side.
NOTE: this doesn't yet remove sessions from protocol.
References #3995