Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal lines overlapping bars #155

Closed
wants to merge 8 commits into from
Closed

Horizontal lines overlapping bars #155

wants to merge 8 commits into from

Conversation

AlexanderK79
Copy link

Following #153 I made an adjustement that resolves the described issue.

Also while scaling the Task height

src/gantt.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@zBritva zBritva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failed:

ERROR: src/gantt.ts:1906:19 - comment must start with a space

@zBritva zBritva requested a review from uve July 9, 2019 12:14
@zBritva
Copy link
Contributor

zBritva commented Jul 9, 2019

@AlexanderK79 Could you please update version number of the visual in pbiviz.json and package.json; And also add short description of fix in changelog.md.
Test are passed, we can merge your changes.
Thanks!

@msftclas
Copy link

msftclas commented Jul 9, 2019

CLA assistant check
All CLA requirements met.

@AlexanderK79
Copy link
Author

I have updated and committed the requested files.... hope I did it right :-)

@zBritva
Copy link
Contributor

zBritva commented Jul 9, 2019

I have updated and committed the requested files.... hope I did it right :-)

Yes, but you forget displayName: "Gantt 2.0.1". You need to change to 2.0.2 also.
PBI displays text as name in UI for users.
Thanks!

@zBritva
Copy link
Contributor

zBritva commented Jul 9, 2019

@AlexanderK79 don't add commits to master, before merge this PR.

@zBritva zBritva closed this Jul 9, 2019
@AlexanderK79
Copy link
Author

OK
sorry!
will pay attention from now on

@th340385
Copy link

th340385 commented Jul 9, 2019

Very new to this; however, will this update be automatically pushed through to Power BI? How long does that take?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants