(Picker) Fix OnChange event for AutoHeight change not firing in custom pages #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: onchange not fired when any outputs undefined chore: npm update and test chore: spelling mistake chore: variable names should be camelCase
Ramakrishnan24689
approved these changes
Sep 28, 2022
Ramakrishnan24689
added a commit
that referenced
this pull request
Sep 30, 2022
* Calendar Test Added - gitignore updated * Removed Shimmer Coverage/ Updated Test Snaps * Udpated Test for Progress Indicator * fix:(Calendar) test failing due to dependency on today's date (#30) * fix: (pivot) width in custom pages (#33) chore: (pivot) npm update - stay with pcf-scripts 1.14.2 due to webpack dependency issue * fix: auto-height in custom pages (#32) fix: onchange not fired when any outputs undefined chore: npm update and test chore: spelling mistake chore: variable names should be camelCase * Facepile component added (#35) * Facepile component added * reactdom-definition * fixing typos * Update Facepile.1033.resx Adding preview tag Co-authored-by: Scott Durow <scott_durow@hotmail.com>
Ramakrishnan24689
added a commit
that referenced
this pull request
Nov 1, 2022
* Calendar Test Added - gitignore updated * Removed Shimmer Coverage/ Updated Test Snaps * Udpated Test for Progress Indicator * fix:(Calendar) test failing due to dependency on today's date (#30) * fix: (pivot) width in custom pages (#33) chore: (pivot) npm update - stay with pcf-scripts 1.14.2 due to webpack dependency issue * fix: auto-height in custom pages (#32) fix: onchange not fired when any outputs undefined chore: npm update and test chore: spelling mistake chore: variable names should be camelCase * Facepile component added (#35) * Facepile component added * reactdom-definition * fixing typos * Update Facepile.1033.resx Adding preview tag * Facepile propertyname changed (#48) * Features/people picker (#46) * PeoplePicker Added * Code refactor and Documentation * Updated readme, fixed typos. * refactor: code optimization-onsearch/retries * Tweaks * refactor : render - pre-selected members * Readme modified * refactor : duplicate code removed * refactor : personakey & presence type change * refactor: presence return type fix Co-authored-by: Scott Durow <scott_durow@hotmail.com> * Searchbox (#49) * Added SearchBox * updated searchbox * added comments to index * renamed component.types.ts and updated searchbox * added tests * enhancement Co-authored-by: Denise Moran <43950360+denisem-msft@users.noreply.github.com> * test: test modified * (People Picker) Deterministic Suggestions Resolution (#51) * fixes issue with suggestions not resolving correctly fixes other minor typos and consistency issues * fix casing on peoplepicker file Co-authored-by: Scott Durow <scott_durow@hotmail.com> Co-authored-by: Denise Moran <43950360+denisem-msft@users.noreply.github.com>
Ramakrishnan24689
added a commit
that referenced
this pull request
Jun 12, 2023
* Calendar Test Added - gitignore updated * Removed Shimmer Coverage/ Updated Test Snaps * Udpated Test for Progress Indicator * fix:(Calendar) test failing due to dependency on today's date (#30) * fix: (pivot) width in custom pages (#33) chore: (pivot) npm update - stay with pcf-scripts 1.14.2 due to webpack dependency issue * fix: auto-height in custom pages (#32) fix: onchange not fired when any outputs undefined chore: npm update and test chore: spelling mistake chore: variable names should be camelCase * Facepile component added (#35) * Facepile component added * reactdom-definition * fixing typos * Update Facepile.1033.resx Adding preview tag * Facepile propertyname changed (#48) * Features/people picker (#46) * PeoplePicker Added * Code refactor and Documentation * Updated readme, fixed typos. * refactor: code optimization-onsearch/retries * Tweaks * refactor : render - pre-selected members * Readme modified * refactor : duplicate code removed * refactor : personakey & presence type change * refactor: presence return type fix Co-authored-by: Scott Durow <scott_durow@hotmail.com> * Searchbox (#49) * Added SearchBox * updated searchbox * added comments to index * renamed component.types.ts and updated searchbox * added tests * enhancement Co-authored-by: Denise Moran <43950360+denisem-msft@users.noreply.github.com> * test: test modified * (People Picker) Deterministic Suggestions Resolution (#51) * fixes issue with suggestions not resolving correctly fixes other minor typos and consistency issues * fix casing on peoplepicker file * Searchbox - fix : custom page width (#52) * Added SearchBox * updated searchbox * added comments to index * renamed component.types.ts and updated searchbox * added tests * enhancement * removed comments from searchbox tests * fix : Addresses CustomPage Width Co-authored-by: Denise Moran <43950360+denisem-msft@users.noreply.github.com> * October release doc updates * refactor: modified create-release-added npm ci * Update Facepile.resx remove additional tags * Searchbox (#56) * updated readme * fix: assigning class to searchbox * feature : set focus Co-authored-by: Denise Moran <43950360+denisem-msft@users.noreply.github.com> * Creatorkit mehdis persona (#47) * Person Component * Adding missed resource properties * Various updates fixing comments from code review * Adding InitialsColors property * removing unused import and fixing readme * fix: component import fix Co-authored-by: Ramakrishnan Raman <raram@microsoft.com> * Feature/searchbox#82 (#131) * feat:#82 - completed * Feature/tooltip (#132) * Added tooltipcontext property * Updated strings * feat:icon tooltip Co-authored-by: Denise Moran <43950360+denisem-msft@users.noreply.github.com> * feat:SubwayNav component added (#133) * feat:SubwayNav component added * feat:spinbutton (#134) * included Spinbtn directory * removing code * duplicate directory mention * adding subwaynav versioning stamp * fix:custom page width issue (#145) * feat:subwaynav showanimation property (#225) * feat:subwaynav showanimation property * updated tests * fixes microsoft/powercat-creator-kit#285 (#226) * fixes microsoft/powercat-creator-kit#316 (#228) * feat: searchbox-defaultvalue-set-option (#230) * feat: searchbox-defaultvalue-set-option * fixes calendar language support (#231) * fixes searchtext bound property (#234) * fixes searchtext bound property * updated testsnap * feat: searchbox bordercolor property (#235) --------- Co-authored-by: Scott Durow <scott_durow@hotmail.com> Co-authored-by: Denise Moran <43950360+denisem-msft@users.noreply.github.com> Co-authored-by: Mehdi Slaoui Andaloussi <slaouist@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are additional flex box styles added when custom pages run inside the model-driven play that are not present when played inside canvas apps or inside the designer studio. This PR adds the new styles to fix this issue. It also addresses some minor spelling/naming issues.
Fixes microsoft/powercat-creator-kit#182 (Picker) Resize event is not fired in model-driven app custom pages