Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pac-cli bump up, envId changes and telemetry update #1047

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

tyaginidhi
Copy link
Contributor

@tyaginidhi tyaginidhi commented Oct 16, 2024

This pull request includes updates to the WebExtensionContext class to support new organizational and environment identifiers, as well as some refactoring and minor version updates. The most important changes include adding new properties for organizationId and environmentId, updating the gulpfile.mjs with a new CLI version, and refactoring telemetry logging.

Enhancements to WebExtensionContext:

  • Added organizationId and environmentId properties to the IWebExtensionContext interface and the WebExtensionContext class. (src/web/client/WebExtensionContext.ts) [1] [2] [3] [4] [5]
  • Updated the initialization logic to set organizationId and environmentId from query parameters and utility functions. (src/web/client/WebExtensionContext.ts)

Refactoring:

  • Removed the logOneDSLogger function and replaced direct calls to it with updated telemetry instantiation. (src/web/client/extension.ts) [1] [2]
  • Updated the getEnvironmentIdFromUrl function to handle potential undefined values more gracefully. (src/web/client/utilities/commonUtil.ts) [1] [2]

Telemetry Updates:

  • Updated telemetry data collection to use the new getEnvironmentIdFromUrl function. (src/web/client/telemetry/webExtensionTelemetry.ts)
  • Added a stub for getEnvironmentIdFromUrl in the telemetry integration tests. (src/web/client/test/integration/webExtensionTelemetry.test.ts)

Version Update:

  • Updated the CLI version from 1.34.4 to 1.35.1 in the gulpfile.mjs. (gulpfile.mjs)

These changes enhance the functionality and maintainability of the WebExtensionContext class and improve the robustness of telemetry logging.

@tyaginidhi tyaginidhi marked this pull request as ready for review October 16, 2024 07:46
@tyaginidhi tyaginidhi requested review from a team as code owners October 16, 2024 07:46
@tyaginidhi tyaginidhi enabled auto-merge (squash) October 16, 2024 07:48
@tyaginidhi tyaginidhi merged commit 96f0aee into main Oct 16, 2024
6 checks passed
@tyaginidhi tyaginidhi deleted the users/nityagi/PACBumpAndotherchanges branch October 16, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants