Apply DOTNET_ROLL_FORWARD to the PAC UI Backend for M1 Macs #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjenni
approved these changes
Jun 28, 2022
tehcrashxor
added a commit
that referenced
this pull request
Jun 29, 2022
tehcrashxor
added a commit
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #215 (and similar to Issue #139 / PR #141), we have issues with running the currently net5.0 PAC on M1 macs when net6.0 has been installed on the machine. This isn't an issue for PAC run in the terminal per the previous fix, but the
DOTNET_ROLL_FORWARDenvironment variable was only set for the terminal PAC instances, and not the PAC process spawned for the UI backend.This was missed in bugbash as the environment variable was set machine wide in our earlier tests that produced the #141 fix, and hadn't since been removed.