Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump werkzeug from 2.2.2 to 2.2.3 in /presidio-image-redactor #1032

Merged
merged 21 commits into from
Feb 28, 2023
Merged

Bump werkzeug from 2.2.2 to 2.2.3 in /presidio-image-redactor #1032

merged 21 commits into from
Feb 28, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 16, 2023

Bumps werkzeug from 2.2.2 to 2.2.3.

Release notes

Sourced from werkzeug's releases.

2.2.3

This is a fix release for the 2.2.x release branch.

This release contains security fixes for:

Changelog

Sourced from werkzeug's changelog.

Version 2.2.3

Released 2023-02-14

  • Ensure that URL rules using path converters will redirect with strict slashes when the trailing slash is missing. :issue:2533
  • Type signature for get_json specifies that return type is not optional when silent=False. :issue:2508
  • parse_content_range_header returns None for a value like bytes */-1 where the length is invalid, instead of raising an AssertionError. :issue:2531
  • Address remaining ResourceWarning related to the socket used by run_simple. Remove prepare_socket, which now happens when creating the server. :issue:2421
  • Update pre-existing headers for multipart/form-data requests with the test client. :issue:2549
  • Fix handling of header extended parameters such that they are no longer quoted. :issue:2529
  • LimitedStream.read works correctly when wrapping a stream that may not return the requested size in one read call. :issue:2558
  • A cookie header that starts with = is treated as an empty key and discarded, rather than stripping the leading ==.
  • Specify a maximum number of multipart parts, default 1000, after which a RequestEntityTooLarge exception is raised on parsing. This mitigates a DoS attack where a larger number of form/file parts would result in disproportionate resource use.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot
Bump werkzeug from 2.2.2 to 2.2.3 in /presidio-image-redactor
7cd87ba 
Bumps [werkzeug](https://github.com/pallets/werkzeug) from 2.2.2 to 2.2.3.
- [Release notes](https://github.com/pallets/werkzeug/releases)
- [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst)
- [Commits](pallets/werkzeug@2.2.2...2.2.3)

---
updated-dependencies:
- dependency-name: werkzeug
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner February 16, 2023 06:52
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 16, 2023
@omri374
Copy link
Contributor

omri374 commented Feb 16, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SharonHart
SharonHart previously approved these changes Feb 20, 2023
View reviewed changes
@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor

SharonHart commented Feb 21, 2023 •
edited
Loading

@omri374 PERSON recognition changed in spacy 3.4.4, now finding first and last names (and with higher scores than full names?), also, just in python 3.7, 3.8, 3.10 (not 3.9) 😕
image

@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart SharonHart mentioned this pull request Feb 21, 2023
Open
5 tasks
@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Feb 21, 2023

@SharonHart the score issue is weird, as we put a 0.85 fixed score for every spacy prediction. My intuition is that the context engine somehow boosts the score in some cases but not others, but that doesn't explain the difference in python versions. I'll give it a deeper look.

@SharonHart
Copy link
Contributor

SharonHart commented Feb 21, 2023 •
edited
Loading

I think that locking spacy solves it @omri374

@SharonHart
Copy link
Contributor

SharonHart commented Feb 21, 2023 •
edited
Loading

Failing on different versions because there is some indetermination
It comes from a bug when we remove duplicates - we take the first element regardless of the score - code pointer
After fixing it to take the higher score it now took a PERSON entity with value '16' and score 1.0 over a real PERSON entity from spacy with score 0.85.
How '16' was identifies as PERSON? another bug in which we treat the DICOM metadata as PHI and add each element to a deny list with PERSON as the entity.

But why it is failing now??? probably spacy in its latest version started finding more PERSON entities that are sometimes overridden and sometimes not when removing duplicates.

@omri374 @niwilso

@SharonHart SharonHart mentioned this pull request Feb 21, 2023
Open
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@niwilso
Copy link
Collaborator

niwilso commented Feb 23, 2023 •
edited
Loading

The current test failures from presidio/presidio-image-redactor/tests/integration/test_dicom_image_pii_verify_engine_integration.py seem to be from analyzer score differences.

Ultimately, the exact score here doesn't matter so long as everything else is correct, so we can remove or set the same "score" for test_eval_results and expected_results before asserting test_eval_results == expected_results.

@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SharonHart
SharonHart previously approved these changes Feb 26, 2023
View reviewed changes
@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit 1d50d41 into main Feb 28, 2023
@omri374 omri374 deleted the dependabot/pip/presidio-image-redactor/werkzeug-2.2.3 branch February 28, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharonHart SharonHart SharonHart approved these changes

@omri374 omri374 omri374 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omri374 @SharonHart @niwilso