Skip to content

Commit

Permalink
[fundamental][bugfix] Pin tenacity<8.4.0 to fix import-linter CI (#…
Browse files Browse the repository at this point in the history
…3424)

# Description

Pin `tenacity` to avoid issue described in
langchain-ai/langchain#22972.

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
  • Loading branch information
zhengfeiwang authored Jun 17, 2024
1 parent 36883b4 commit 01267fd
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_doc_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
shell: powershell
working-directory: scripts/docs/
run: |-
pip install langchain
pip install langchain tenacity<8.4.0
./doc_generation.ps1 -WithReferenceDoc:$true -WarningAsError:$true
# Note: We have this job separately because some error may missing when build link check exists.
Expand Down Expand Up @@ -85,5 +85,5 @@ jobs:
shell: powershell
working-directory: scripts/docs/
run: |-
pip install langchain
pip install langchain tenacity<8.4.0
./doc_generation.ps1 -WithReferenceDoc:$true -WarningAsError:$true -BuildLinkCheck
2 changes: 1 addition & 1 deletion .github/workflows/promptflow-executor-e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ jobs:
run: |
gci env:* | sort-object name
az account show
pip install langchain-community
pip install langchain-community tenacity<8.4.0
# numexpr is required by langchain in e2e tests.
pip install numexpr
python scripts/building/run_coverage_tests.py `
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/promptflow-executor-unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ jobs:
run: |
gci env:* | sort-object name
az account show
pip install langchain-community
pip install langchain-community tenacity<8.4.0
python scripts/building/run_coverage_tests.py `
-p ${{ env.testWorkingDirectory }}/promptflow `
-t ${{ env.testWorkingDirectory }}/tests/executor/unittests `
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/promptflow-import-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@ jobs:
echo "=== promptflow-azure full lints ==="
poetry run pip install langchain
poetry run pip install "tenacity<8.4.0"
poetry run python ${{ github.workspace }}/scripts/import_linter/import_linter.py

0 comments on commit 01267fd

Please sign in to comment.