Skip to content

Commit

Permalink
[tracing][bugfix] Use eval run name instead of root span name (#2590)
Browse files Browse the repository at this point in the history
# Description

For eval line run(s), use run name, instead of root span name.

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
  • Loading branch information
zhengfeiwang authored Apr 1, 2024
1 parent 1c904f0 commit a700ec0
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/promptflow-devkit/promptflow/_sdk/entities/_trace.py
Original file line number Diff line number Diff line change
Expand Up @@ -457,10 +457,7 @@ def _append_evaluations(self, evaluations: typing.List["LineRun"]) -> None:
for evaluation in evaluations:
if self.evaluations is None:
self.evaluations = dict()
# # TODO: 3050320 - make evaluation name equal to batch run name
# # need to update this once UX update their logic
# eval_name = evaluation.run if evaluation.run is not None else evaluation.name
eval_name = evaluation.name
eval_name = evaluation.run if evaluation.run is not None else evaluation.name
self.evaluations[eval_name] = evaluation

def _to_rest_object(self) -> typing.Dict:
Expand Down

0 comments on commit a700ec0

Please sign in to comment.