Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSI installation scripts #1992

Merged
merged 9 commits into from
Feb 7, 2024
Merged

Fix MSI installation scripts #1992

merged 9 commits into from
Feb 7, 2024

Conversation

YingChen1996
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@YingChen1996 YingChen1996 requested a review from a team as a code owner February 6, 2024 13:36
@YingChen1996 YingChen1996 requested a review from a team as a code owner February 7, 2024 03:06
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

SDK CLI Global Config Test Result chenyin/fix_msi_install

2 tests   2 ✅  47s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit a165a35.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 7, 2024

promptflow SDK CLI Azure E2E Test Result chenyin/fix_msi_install

  4 files    4 suites   3m 19s ⏱️
148 tests 127 ✅ 21 💤 0 ❌
592 runs  508 ✅ 84 💤 0 ❌

Results for commit a165a35.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 7, 2024

SDK CLI Test Result chenyin/fix_msi_install

   12 files     12 suites   39m 15s ⏱️
  418 tests   400 ✅ 18 💤 0 ❌
1 672 runs  1 600 ✅ 72 💤 0 ❌

Results for commit a165a35.

♻️ This comment has been updated with latest results.

wangchao1230
wangchao1230 previously approved these changes Feb 7, 2024
@YingChen1996 YingChen1996 merged commit c8ea951 into main Feb 7, 2024
33 checks passed
@YingChen1996 YingChen1996 deleted the chenyin/fix_msi_install branch February 7, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants