Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Executor] Add resume to batch engine #2003

Merged
merged 17 commits into from
Feb 23, 2024
Merged

[Feature][Executor] Add resume to batch engine #2003

merged 17 commits into from
Feb 23, 2024

Conversation

Jasmin3q
Copy link
Contributor

@Jasmin3q Jasmin3q commented Feb 8, 2024

Description

This pull request adds the resume function for batch run in batch engine.

The most important changes are:

  1. Addition of new feature:

    • src/promptflow/promptflow/batch/_batch_engine.py: Added logic to handle resuming from a previous run. In resume run, the previous completed and failed lines are dropped and the other lines are processed. Added _copy_previous_run_result to load previous flow run output from output.jsonl, copy image files to output_dir, and extract aggregation inputs for aggregation node.
  2. Addition of new utility functions:

  3. Rearrange functions:

  4. Changes to test files:

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Jasmin3q Jasmin3q requested review from a team as code owners February 8, 2024 03:46
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

SDK CLI Global Config Test Result shimin/resume

2 tests   2 ✅  50s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 4f81337.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 8, 2024

promptflow SDK CLI Azure E2E Test Result shimin/resume

  4 files    4 suites   3m 20s ⏱️
149 tests 128 ✅ 21 💤 0 ❌
596 runs  512 ✅ 84 💤 0 ❌

Results for commit 4f81337.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 8, 2024

SDK CLI Test Result shimin/resume

   12 files     12 suites   41m 5s ⏱️
  424 tests   408 ✅ 16 💤 0 ❌
1 696 runs  1 632 ✅ 64 💤 0 ❌

Results for commit 4f81337.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 8, 2024

Executor Unit Test Result shimin/resume

735 tests   735 ✅  45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 4f81337.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 8, 2024

Executor E2E Test Result shimin/resume

198 tests   196 ✅  4m 12s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 4f81337.

♻️ This comment has been updated with latest results.

thy09
thy09 previously approved these changes Feb 23, 2024
@Jasmin3q Jasmin3q merged commit 61356cc into main Feb 23, 2024
42 checks passed
@Jasmin3q Jasmin3q changed the title Add resume to batch engine [Feature][Executor] Add resume to batch engine Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants