Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[promptflow][internal] Support query spans via trace id & add hash header in list line runs #2069

Merged
merged 9 commits into from
Feb 23, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Feb 21, 2024

Description

This PR targets to refine the trace management APIs:

  • Revert evaluations schema change happened in [promptflow][internal] Support trace UI page #2035 , also update the JS bundle for this change.
  • Add query parameter trace_ids for /v1.0/Spans/list
  • Add header X-Line-Runs-List-Hash in header for /v1.0/LineRuns/list: UX can use it to determine if the line runs have changed

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang requested a review from a team as a code owner February 21, 2024 09:32
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Feb 21, 2024
Copy link

github-actions bot commented Feb 21, 2024

SDK CLI Global Config Test Result zhengfei/feature/query-spans-by-trace-ids

2 tests   2 ✅  54s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 37917af.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 21, 2024

promptflow SDK CLI Azure E2E Test Result zhengfei/feature/query-spans-by-trace-ids

  4 files    4 suites   3m 23s ⏱️
149 tests 128 ✅ 21 💤 0 ❌
596 runs  512 ✅ 84 💤 0 ❌

Results for commit 37917af.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 21, 2024

SDK CLI Test Result zhengfei/feature/query-spans-by-trace-ids

   12 files     12 suites   41m 12s ⏱️
  424 tests   408 ✅ 16 💤 0 ❌
1 696 runs  1 632 ✅ 64 💤 0 ❌

Results for commit 37917af.

♻️ This comment has been updated with latest results.

brynn-code
brynn-code previously approved these changes Feb 21, 2024
wangchao1230
wangchao1230 previously approved these changes Feb 23, 2024
@zhengfeiwang zhengfeiwang merged commit 10c7e0c into main Feb 23, 2024
32 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/feature/query-spans-by-trace-ids branch February 23, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants