Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connection] Support aoai & oai connection from_env #2219

Merged
merged 3 commits into from
Mar 6, 2024
Merged

[Connection] Support aoai & oai connection from_env #2219

merged 3 commits into from
Mar 6, 2024

Conversation

brynn-code
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@brynn-code
Support aoai & oai from_env
d2e0ec6 
Signed-off-by: Brynn Yin <biyi@microsoft.com>
@brynn-code brynn-code requested review from a team as code owners March 5, 2024 11:31
@github-actions github-actions bot added documentation Improvements or additions to documentation sdk prompt flow SDK promptflow labels Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

SDK CLI Global Config Test Result brynn/support-aoai-oai-from-env

2 tests   2 ✅  43s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 7cbc26c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

Executor Unit Test Result brynn/support-aoai-oai-from-env

751 tests   751 ✅  43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 7cbc26c.

♻️ This comment has been updated with latest results.

@brynn-code
Update to OPENAI_API_VERSION
343d29e 
Signed-off-by: Brynn Yin <biyi@microsoft.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result brynn/support-aoai-oai-from-env

  4 files    4 suites   3m 46s ⏱️
168 tests 149 ✅ 19 💤 0 ❌
672 runs  596 ✅ 76 💤 0 ❌

Results for commit 7cbc26c.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added the examples Improvements on examples label Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

Executor E2E Test Result brynn/support-aoai-oai-from-env

210 tests   208 ✅  6m 28s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 7cbc26c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

SDK CLI Test Result brynn/support-aoai-oai-from-env

   12 files     12 suites   41m 7s ⏱️
  447 tests   430 ✅ 17 💤 0 ❌
1 788 runs  1 720 ✅ 68 💤 0 ❌

Results for commit 7cbc26c.

♻️ This comment has been updated with latest results.

@brynn-code
Remove default connection name
7cbc26c 
Signed-off-by: Brynn Yin <biyi@microsoft.com>
@brynn-code brynn-code merged commit 7bd946e into main Mar 6, 2024
44 checks passed
@brynn-code brynn-code deleted the brynn/support-aoai-oai-from-env branch March 6, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@D-W- D-W- D-W- approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples Improvements on examples promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brynn-code @D-W- @wangchao1230