Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve created_by info for local to cloud trace #2232

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Improve created_by info for local to cloud trace #2232

merged 3 commits into from
Mar 12, 2024

Conversation

huaiyan
Copy link
Contributor

@huaiyan huaiyan commented Mar 6, 2024 •
edited
Loading

Description

  1. Add name in created_by info (For UI show)
  2. Call method to get created_by in each request instead of starting service
    As info required by local to cloud trace, don't depend on Configuration file is clearer.

image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@huaiyan huaiyan requested a review from a team as a code owner March 6, 2024 09:17
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Mar 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

SDK CLI Global Config Test Result devs/robbenwang_retrieve_created_by

2 tests   2 ✅  45s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 2b6212c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result devs/robbenwang_retrieve_created_by

  4 files    4 suites   3m 45s ⏱️
168 tests 149 ✅ 19 💤 0 ❌
672 runs  596 ✅ 76 💤 0 ❌

Results for commit 2b6212c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

SDK CLI Test Result devs/robbenwang_retrieve_created_by

   12 files     12 suites   40m 23s ⏱️
  451 tests   433 ✅ 18 💤 0 ❌
1 804 runs  1 732 ✅ 72 💤 0 ❌

Results for commit 2b6212c.

♻️ This comment has been updated with latest results.

@huaiyan huaiyan force-pushed the devs/robbenwang_retrieve_created_by branch from 419ca8b to 626ad5b Compare March 8, 2024 08:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024 •
edited
Loading

promptflow-tracing unit test result devs/robbenwang_retrieve_created_by

 4 files   4 suites   31s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
16 runs  16 ✅ 0 💤 0 ❌

Results for commit 2b6212c.

♻️ This comment has been updated with latest results.

@huaiyan huaiyan requested review from riddlexu and zhengfeiwang March 8, 2024 09:01
@huaiyan huaiyan force-pushed the devs/robbenwang_retrieve_created_by branch from 2915670 to 4373b6a Compare March 8, 2024 10:27
@huaiyan huaiyan force-pushed the devs/robbenwang_retrieve_created_by branch from 4373b6a to d06b623 Compare March 8, 2024 10:36
@huaiyan huaiyan force-pushed the devs/robbenwang_retrieve_created_by branch from d06b623 to cf9f6f8 Compare March 11, 2024 03:03
@huaiyan huaiyan force-pushed the devs/robbenwang_retrieve_created_by branch from cf9f6f8 to 11c037e Compare March 11, 2024 03:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

promptflow-tracing e2e test result devs/robbenwang_retrieve_created_by

 4 files   4 suites   1m 43s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
32 runs  32 ✅ 0 💤 0 ❌

Results for commit 2b6212c.

♻️ This comment has been updated with latest results.

@huaiyan huaiyan force-pushed the devs/robbenwang_retrieve_created_by branch from 11c037e to 232a632 Compare March 11, 2024 06:10
@huaiyan huaiyan force-pushed the devs/robbenwang_retrieve_created_by branch from 232a632 to b29c1b8 Compare March 11, 2024 06:30
@huaiyan huaiyan force-pushed the devs/robbenwang_retrieve_created_by branch from b29c1b8 to 61f2a40 Compare March 11, 2024 10:26
@huaiyan huaiyan force-pushed the devs/robbenwang_retrieve_created_by branch from 61f2a40 to 2b6212c Compare March 12, 2024 05:58
@huaiyan huaiyan merged commit 840fa04 into main Mar 12, 2024
47 checks passed
@huaiyan huaiyan deleted the devs/robbenwang_retrieve_created_by branch March 12, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

@riddlexu riddlexu riddlexu approved these changes

Assignees
No one assigned
Labels
promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huaiyan @riddlexu @zhengfeiwang