Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LLM and Embedding span attributes #2270

Merged
merged 11 commits into from
Mar 11, 2024

Conversation

zzn2
Copy link
Contributor

@zzn2 zzn2 commented Mar 8, 2024

Description

Rename LLM and Embedding span attributes to align with the OpenTelemetry convention.
See #2266 for details.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zzn2 zzn2 requested review from a team as code owners March 8, 2024 06:52
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

SDK CLI Global Config Test Result zhizhu/20240308-rename-llm-span-attributes

2 tests   2 ✅  43s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 27b4599.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 8, 2024

promptflow-tracing unit test result zhizhu/20240308-rename-llm-span-attributes

 4 files   4 suites   23s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
16 runs  16 ✅ 0 💤 0 ❌

Results for commit 27b4599.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 8, 2024

Executor Unit Test Result zhizhu/20240308-rename-llm-span-attributes

754 tests   754 ✅  55s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 27b4599.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 8, 2024

promptflow SDK CLI Azure E2E Test Result zhizhu/20240308-rename-llm-span-attributes

  4 files    4 suites   3m 44s ⏱️
168 tests 149 ✅ 19 💤 0 ❌
672 runs  596 ✅ 76 💤 0 ❌

Results for commit 27b4599.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 8, 2024

Executor E2E Test Result zhizhu/20240308-rename-llm-span-attributes

211 tests   209 ✅  7m 24s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 27b4599.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 8, 2024

SDK CLI Test Result zhizhu/20240308-rename-llm-span-attributes

   12 files     12 suites   41m 50s ⏱️
  451 tests   434 ✅ 17 💤 0 ❌
1 804 runs  1 736 ✅ 68 💤 0 ❌

Results for commit 27b4599.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 11, 2024

promptflow-tracing e2e test result zhizhu/20240308-rename-llm-span-attributes

 4 files   4 suites   1m 45s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
32 runs  32 ✅ 0 💤 0 ❌

Results for commit 27b4599.

♻️ This comment has been updated with latest results.

@zzn2 zzn2 changed the title Rename LLM span attributes Rename LLM and Embedding span attributes Mar 11, 2024
@zzn2 zzn2 merged commit cd65b2e into main Mar 11, 2024
57 checks passed
@zzn2 zzn2 deleted the zhizhu/20240308-rename-llm-span-attributes branch March 11, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants