-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Remove variant_id in all executor related logic. #2274
Conversation
SDK CLI Global Config Test Result heta/remove-variant-id2 tests 2 ✅ 50s ⏱️ Results for commit 4060eaf. ♻️ This comment has been updated with latest results. |
promptflow-tracing unit test result heta/remove-variant-id 4 files 4 suites 22s ⏱️ Results for commit 4060eaf. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result heta/remove-variant-id754 tests 754 ✅ 48s ⏱️ Results for commit 4060eaf. ♻️ This comment has been updated with latest results. |
promptflow SDK CLI Azure E2E Test Result heta/remove-variant-id 4 files 4 suites 3m 44s ⏱️ Results for commit 4060eaf. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result heta/remove-variant-id211 tests 209 ✅ 8m 47s ⏱️ Results for commit 4060eaf. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result heta/remove-variant-id 12 files 12 suites 41m 20s ⏱️ Results for commit 4060eaf. |
Description
Remove variant_id concept in all executor related logic since it is used only for legacy logic.
This pull request primarily involves the removal of
variant_id
from various methods across multiple files in thesrc/promptflow/promptflow/
directory. Thevariant_id
parameter was previously used in the initialization, copying, and execution of flow runs and node runs, but it has now been removed from these processes.Removal of
variant_id
fromFlowExecutionContext
:src/promptflow/promptflow/_core/flow_execution_context.py
: Removedvariant_id
from the__init__
method,copy
method,_prepare_node_run
method, andbypass_node
method. [1] [2] [3] [4]Removal of
variant_id
fromRunTracker
:src/promptflow/promptflow/_core/run_tracker.py
: Removedvariant_id
from thestart_flow_run
method andbypass_node_run
method. [1] [2] [3] [4]Removal of
variant_id
fromFlowExecutor
:src/promptflow/promptflow/executor/flow_executor.py
: Removedvariant_id
from theexec
method,exec_line
method,exec_line_async
method,_exec
method, and_exec_async
method. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines