Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Remove variant_id in all executor related logic. #2274

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

thy09
Copy link
Contributor

@thy09 thy09 commented Mar 8, 2024

Description

Remove variant_id concept in all executor related logic since it is used only for legacy logic.

This pull request primarily involves the removal of variant_id from various methods across multiple files in the src/promptflow/promptflow/ directory. The variant_id parameter was previously used in the initialization, copying, and execution of flow runs and node runs, but it has now been removed from these processes.

Removal of variant_id from FlowExecutionContext:

Removal of variant_id from RunTracker:

Removal of variant_id from FlowExecutor:

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@thy09 thy09 requested a review from a team as a code owner March 8, 2024 08:14
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

SDK CLI Global Config Test Result heta/remove-variant-id

2 tests   2 ✅  50s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 4060eaf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 8, 2024

promptflow-tracing unit test result heta/remove-variant-id

 4 files   4 suites   22s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
16 runs  16 ✅ 0 💤 0 ❌

Results for commit 4060eaf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 8, 2024

Executor Unit Test Result heta/remove-variant-id

754 tests   754 ✅  48s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 4060eaf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 8, 2024

promptflow SDK CLI Azure E2E Test Result heta/remove-variant-id

  4 files    4 suites   3m 44s ⏱️
168 tests 149 ✅ 19 💤 0 ❌
672 runs  596 ✅ 76 💤 0 ❌

Results for commit 4060eaf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 8, 2024

Executor E2E Test Result heta/remove-variant-id

211 tests   209 ✅  8m 47s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 4060eaf.

♻️ This comment has been updated with latest results.

@thy09 thy09 requested a review from a team as a code owner March 8, 2024 08:28
Copy link

github-actions bot commented Mar 8, 2024

SDK CLI Test Result heta/remove-variant-id

   12 files     12 suites   41m 20s ⏱️
  451 tests   434 ✅ 17 💤 0 ❌
1 804 runs  1 736 ✅ 68 💤 0 ❌

Results for commit 4060eaf.

@thy09 thy09 merged commit c9165c3 into main Mar 8, 2024
49 checks passed
@thy09 thy09 deleted the heta/remove-variant-id branch March 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants