Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset user agent for each requests in local pfs #2284

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

elliotzh
Copy link
Contributor

@elliotzh elliotzh commented Mar 11, 2024

Description

This pull request primarily involves 2 changes:

  1. specifying user agent for telemetry from local PFS without touching OperationContext, which behaves as a global context and will be shared among requests;
  2. support using the same port file as msi by set up environment variable.

User Agent Handling:

Client Request Processing:

New Methods:

Test Cases:

Other Changes:

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@elliotzh elliotzh requested review from a team as code owners March 11, 2024 04:47
@github-actions github-actions bot added sdk prompt flow SDK promptflow executor The changes related to the execution of the flow labels Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

SDK CLI Global Config Test Result zhangxingzhi/reset-user-agent-for-each-pfs-request

2 tests   2 ✅  51s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit aa7588b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 11, 2024

promptflow-tracing unit test result zhangxingzhi/reset-user-agent-for-each-pfs-request

 4 files   4 suites   22s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
16 runs  16 ✅ 0 💤 0 ❌

Results for commit aa7588b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 11, 2024

promptflow-tracing e2e test result zhangxingzhi/reset-user-agent-for-each-pfs-request

 4 files   4 suites   1m 40s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
32 runs  32 ✅ 0 💤 0 ❌

Results for commit aa7588b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 11, 2024

Executor Unit Test Result zhangxingzhi/reset-user-agent-for-each-pfs-request

754 tests   754 ✅  3m 53s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit aa7588b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 11, 2024

promptflow SDK CLI Azure E2E Test Result zhangxingzhi/reset-user-agent-for-each-pfs-request

  4 files    4 suites   3m 48s ⏱️
168 tests 149 ✅ 19 💤 0 ❌
672 runs  596 ✅ 76 💤 0 ❌

Results for commit aa7588b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 11, 2024

Executor E2E Test Result zhangxingzhi/reset-user-agent-for-each-pfs-request

210 tests   208 ✅  7m 25s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit aa7588b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 11, 2024

SDK CLI Test Result zhangxingzhi/reset-user-agent-for-each-pfs-request

   12 files     12 suites   40m 25s ⏱️
  452 tests   434 ✅ 18 💤 0 ❌
1 808 runs  1 736 ✅ 72 💤 0 ❌

Results for commit aa7588b.

♻️ This comment has been updated with latest results.

@elliotzh elliotzh force-pushed the zhangxingzhi/reset-user-agent-for-each-pfs-request branch from 27ea2f4 to 2657a08 Compare March 11, 2024 06:24
@elliotzh elliotzh force-pushed the zhangxingzhi/reset-user-agent-for-each-pfs-request branch from 2657a08 to ee5e471 Compare March 11, 2024 06:47
@elliotzh elliotzh requested a review from a team as a code owner March 11, 2024 06:47
@elliotzh elliotzh force-pushed the zhangxingzhi/reset-user-agent-for-each-pfs-request branch from ee5e471 to 7c01e62 Compare March 11, 2024 07:23
PeiwenGaoMS
PeiwenGaoMS previously approved these changes Mar 12, 2024
@elliotzh elliotzh force-pushed the zhangxingzhi/reset-user-agent-for-each-pfs-request branch from f3b5e3d to aa7588b Compare March 12, 2024 08:38
@elliotzh elliotzh merged commit 0fc9c4e into main Mar 12, 2024
57 checks passed
@elliotzh elliotzh deleted the zhangxingzhi/reset-user-agent-for-each-pfs-request branch March 12, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants