Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recording and remove None fields when create recording hash. #2302

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

crazygao
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

SDK CLI Global Config Test Result yigao/re-recording

2 tests   2 ✅  42s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 17306ec.

Copy link

promptflow-tracing unit test result yigao/re-recording

 4 files   4 suites   21s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
16 runs  16 ✅ 0 💤 0 ❌

Results for commit 17306ec.

Copy link

promptflow-tracing e2e test result yigao/re-recording

 4 files   4 suites   1m 43s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
32 runs  32 ✅ 0 💤 0 ❌

Results for commit 17306ec.

Copy link

promptflow SDK CLI Azure E2E Test Result yigao/re-recording

  4 files    4 suites   3m 46s ⏱️
168 tests 149 ✅ 19 💤 0 ❌
672 runs  596 ✅ 76 💤 0 ❌

Results for commit 17306ec.

Copy link

SDK CLI Test Result yigao/re-recording

   12 files     12 suites   41m 17s ⏱️
  451 tests   433 ✅ 18 💤 0 ❌
1 804 runs  1 732 ✅ 72 💤 0 ❌

Results for commit 17306ec.

@crazygao crazygao merged commit 45afc50 into main Mar 12, 2024
45 checks passed
@crazygao crazygao deleted the yigao/re-recording branch March 12, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants