Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Input/Output Events to OpenTelemetry Spans in PromptFlow #2489

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

liucheng-ms
Copy link
Contributor

@liucheng-ms liucheng-ms commented Mar 26, 2024

Description

This pull request introduces changes to the tracing functionality in PromptFlow. Specifically, it adds input and output events to the OpenTelemetry spans. The event names are promptflow.function.inputs and promptflow.function.output, and their attributes contain a payload which is a JSON dump of the input/output values. This enhancement will provide more detailed tracing information and facilitate debugging and performance monitoring.

This PR also includes updates to the relevant unit tests to validate these new events and their payloads.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@liucheng-ms liucheng-ms marked this pull request as ready for review March 26, 2024 11:59
@liucheng-ms liucheng-ms requested a review from a team as a code owner March 26, 2024 11:59
Copy link

github-actions bot commented Mar 26, 2024

promptflow-tracing test result

 12 files   12 suites   3m 45s ⏱️
  9 tests   9 ✅ 0 💤 0 ❌
108 runs  108 ✅ 0 💤 0 ❌

Results for commit 5134767.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 26, 2024

promptflow SDK CLI Azure E2E Test Result liucheng/20240326_span_event

  4 files    4 suites   5m 28s ⏱️
196 tests 176 ✅ 20 💤 0 ❌
784 runs  704 ✅ 80 💤 0 ❌

Results for commit 5134767.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 26, 2024

Executor E2E Test Result liucheng/20240326_span_event

217 tests   215 ✅  5m 8s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 5134767.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 26, 2024

SDK CLI Test Result liucheng/20240326_span_event

   12 files     12 suites   49m 4s ⏱️
  499 tests   480 ✅ 19 💤 0 ❌
1 996 runs  1 920 ✅ 76 💤 0 ❌

Results for commit 5134767.

♻️ This comment has been updated with latest results.

@liucheng-ms liucheng-ms merged commit 758dcb9 into main Mar 27, 2024
59 checks passed
@liucheng-ms liucheng-ms deleted the liucheng/20240326_span_event branch March 27, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants