Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update imports in doc and examples #2499

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

wangchao1230
Copy link
Contributor

@wangchao1230 wangchao1230 commented Mar 27, 2024

Description

Avoid imports from root namespace in docs & examples.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@wangchao1230 wangchao1230 requested review from a team as code owners March 27, 2024 07:06
@github-actions github-actions bot added documentation Improvements or additions to documentation examples Improvements on examples labels Mar 27, 2024
crazygao
crazygao previously approved these changes Mar 27, 2024
crazygao
crazygao previously approved these changes Mar 27, 2024
brynn-code
brynn-code previously approved these changes Mar 27, 2024
@wangchao1230 wangchao1230 dismissed stale reviews from brynn-code and crazygao via a2eb948 March 27, 2024 09:30
@wangchao1230 wangchao1230 changed the title update imports in doc examples update imports in doc and examples Mar 29, 2024
@wangchao1230 wangchao1230 merged commit ef87727 into main Mar 29, 2024
56 checks passed
@wangchao1230 wangchao1230 deleted the clwan/update_imports_in_doc_examples branch March 29, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples Improvements on examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants