Move flow folder, fix tool warning and fix progress bar #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chjinche
reviewed
Mar 28, 2024
| log_pattern = re.compile(r".*execution.bulk\s+INFO\s+Finished (\d+) / (\d+) lines\.") | ||
| finished_log_pattern = re.compile(r".*execution.bulk\s+INFO\s+Finished (\d+) / (\d+) lines\.") | ||
| progress_log_pattern = re.compile( | ||
| r".*execution\.bulk\s+INFO\s+\[Lines]\s+\[Finished:\s+(\d+)]\s+\[Processing:\s+(\d+)]\s+\[Pending:\s+(\d+)]" |
There was a problem hiding this comment.
Can we ignore [Lines] from regrex pattern? Maybe more robust.
There was a problem hiding this comment.
updated. please check again
chjinche
reviewed
Mar 28, 2024
| total = finished + processing + pending | ||
| if progress_bar is None: | ||
| progress_bar = tqdm(total=total, desc="Processing", miniters=1, file=sys.stdout) | ||
| time.sleep(0.1) # wait for 0.1 second to show the progress bar on next line |
There was a problem hiding this comment.
due to tqdm issue, need to wait for 0.1 second between progress bar initialization and first update.
There was a problem hiding this comment.
updated to use mininterval
… path and fix comment
added 2 commits
March 28, 2024 15:24
github-actions
bot
added
the
documentation
added 2 commits
March 28, 2024 15:43
chjinche
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move flow folder, fix tool warning and fix progress bar.
Doc CI check: https://github.com/microsoft/promptflow/actions/runs/8464028391
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines