Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multimedia_utils. #2585

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fix multimedia_utils. #2585

merged 1 commit into from
Apr 1, 2024

Conversation

codingrabbitt1
Copy link
Contributor

@codingrabbitt1 codingrabbitt1 commented Apr 1, 2024

Description

Fix some bugs caused by this pr #2287

  1. Fix MultimediaProcessor._process_multimedia_dict_recursively.
  2. Because this pr 2287 fully refactored multimedia_utils, some changes made to the file by others during development were ignored. Specific changes:

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@codingrabbitt1 codingrabbitt1 requested review from a team as code owners April 1, 2024 10:08
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

promptflow-core test result

 12 files   12 suites   2m 54s ⏱️
 11 tests  11 ✅ 0 💤 0 ❌
132 runs  132 ✅ 0 💤 0 ❌

Results for commit 2039569.

Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Global Config Test Result wangbin/contract_version1

3 tests   3 ✅  45s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 2039569.

Copy link

github-actions bot commented Apr 1, 2024

promptflow SDK CLI Azure E2E Test Result wangbin/contract_version1

  4 files    4 suites   4m 1s ⏱️
202 tests 182 ✅ 20 💤 0 ❌
808 runs  728 ✅ 80 💤 0 ❌

Results for commit 2039569.

Copy link

github-actions bot commented Apr 1, 2024

Executor Unit Test Result wangbin/contract_version1

754 tests   754 ✅  3m 44s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 2039569.

Copy link

github-actions bot commented Apr 1, 2024

Executor E2E Test Result wangbin/contract_version1

217 tests   215 ✅  6m 5s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 2039569.

Copy link

github-actions bot commented Apr 1, 2024

SDK CLI Test Result wangbin/contract_version1

   12 files     12 suites   50m 59s ⏱️
  521 tests   502 ✅ 19 💤 0 ❌
2 084 runs  2 008 ✅ 76 💤 0 ❌

Results for commit 2039569.

@codingrabbitt1 codingrabbitt1 merged commit 7d125a7 into main Apr 1, 2024
58 checks passed
@codingrabbitt1 codingrabbitt1 deleted the wangbin/contract_version1 branch April 1, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants