feat: enable validation in pf.flow._save #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promptflow SDK CLI Azure E2E Test Result zhangxingzhi/pf-save-public-api 4 files 4 suites 3m 59s ⏱️ Results for commit c5a7cac. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result zhangxingzhi/pf-save-public-api 12 files 12 suites 48m 53s ⏱️ Results for commit c5a7cac. ♻️ This comment has been updated with latest results. |
github-actions
bot
added
promptflow
executor
SDK CLI Global Config Test Result zhangxingzhi/pf-save-public-api3 tests 3 ✅ 52s ⏱️ Results for commit c5a7cac. ♻️ This comment has been updated with latest results. |
promptflow-core test result 12 files 12 suites 2m 57s ⏱️ Results for commit c5a7cac. ♻️ This comment has been updated with latest results. |
elliotzh
changed the title
D-W-
reviewed
Apr 3, 2024
D-W-
previously approved these changes
Apr 3, 2024
thy09
reviewed
Apr 7, 2024
wangchao1230
reviewed
Apr 7, 2024
src/promptflow-devkit/promptflow/_sdk/operations/_flow_operations.py
Outdated
Show resolved
Hide resolved
wangchao1230
reviewed
Apr 7, 2024
wangchao1230
reviewed
Apr 7, 2024
wangchao1230
reviewed
Apr 7, 2024
elliotzh
force-pushed
the
zhangxingzhi/pf-save-public-api
branch
from
0dcfde2 to
08d578c
Compare
elliotzh
force-pushed
the
zhangxingzhi/pf-save-public-api
branch
from
08d578c to
39e53b8
Compare
thy09
previously approved these changes
Apr 7, 2024
elliotzh
force-pushed
the
zhangxingzhi/pf-save-public-api
branch
from
a459064 to
b3fb5cf
Compare
wangchao1230
reviewed
Apr 7, 2024
src/promptflow-devkit/promptflow/_sdk/operations/_flow_operations.py
Outdated
Show resolved
Hide resolved
elliotzh
commented
Apr 8, 2024
thy09
reviewed
Apr 8, 2024
elliotzh
force-pushed
the
zhangxingzhi/pf-save-public-api
branch
from
89f3946 to
9742c6e
Compare
elliotzh
force-pushed
the
zhangxingzhi/pf-save-public-api
branch
from
9742c6e to
c5a7cac
Compare
thy09
approved these changes
Apr 8, 2024
wangchao1230
reviewed
Apr 8, 2024
src/promptflow/tests/test_configs/functions/class_init_complicated_ports/hello.py
Show resolved
Hide resolved
wangchao1230
approved these changes
Apr 8, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FlexFlowno longer inheritFlowConnectionparams for class init (save & meta generation)pf.flow._savepf.flows._infer_signatureNote that we haven't checked whether inputs/outputs are of type
dictfor now as they're not recognized by current meta generation logic. Will do this in a separate PR as it may involve changes on low-level utils.All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines