Distinguish flex flow and dag flow(use flow.flex.yaml for flex flow, flow.dag.yaml for dag flow) #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promptflow-core test result 12 files 12 suites 2m 59s ⏱️ Results for commit 7baf7ef. ♻️ This comment has been updated with latest results. |
promptflow SDK CLI Azure E2E Test Result chenyzhang/distinguish_flex_and_dag 4 files 4 suites 3m 59s ⏱️ Results for commit 7baf7ef. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result chenyzhang/distinguish_flex_and_dag 12 files 12 suites 48m 39s ⏱️ Results for commit 7baf7ef. ♻️ This comment has been updated with latest results. |
github-actions
bot
added
promptflow-core
promptflow-devkit
promptflow-azure
and removed
promptflow
labels
SDK CLI Global Config Test Result chenyzhang/distinguish_flex_and_dag3 tests 3 ✅ 49s ⏱️ Results for commit 7baf7ef. ♻️ This comment has been updated with latest results. |
Stephen1993
changed the title
wangchao1230
reviewed
Apr 7, 2024
wangchao1230
reviewed
Apr 7, 2024
wangchao1230
previously approved these changes
Apr 7, 2024
0mza987
reviewed
Apr 7, 2024
0mza987
approved these changes
Apr 7, 2024
wangchao1230
approved these changes
Apr 7, 2024
7 tasks
Stephen1993
added a commit
that referenced
this pull request
Apr 8, 2024
…to obtain the flow path and flow file. (#2662) # Description Please add an informative description that covers that changes made by the pull request and link all relevant issues. Base this [PR](#2626): Distinguish flex flow and dag flow(use flow.flex.yaml for flex flow, flow.dag.yaml for dag flow), And next [PR](#2548): Migrate the yaml used by the eager flow to flow.flex.yaml, code support both flow.flex.yaml and flow.dag.yaml. To standardize the construction method of flow paths and flow files: 1. Delete **DAG_FILE_NAME** constant and use the **resolve_flow_path** function to obtain the flow path and flow file. 2. Using **FLOW_DAG_YAML** instead of **DAG_FILE_NAME** . # All Promptflow Contribution checklist: - [x] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [x] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
It is necessary to distinguish between the flow yaml used by the eager flow and the dag flow (flex yaml and dag yaml), and modify the code to enable the eager flow to use flex yaml correctly and to enable the code to automatically recognize flex yaml and dag flex, which is divided into two steps:
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines