Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sdk to support file_path type #621

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Update sdk to support file_path type #621

merged 5 commits into from
Sep 28, 2023

Conversation

liuyuhang13
Copy link
Contributor

@liuyuhang13 liuyuhang13 commented Sep 26, 2023 •
edited
Loading

Description

Update SDK, support file_path when generate tools meta.

Test

Test result with private sdk in build 20230925.4_105908422:
image
image
image
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@liuyuhang13 liuyuhang13 requested a review from a team as a code owner September 26, 2023 08:59
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 26, 2023 08:59 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 26, 2023 08:59 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 26, 2023 08:59 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 26, 2023 08:59 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 26, 2023 08:59 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

SDK CLI Global Config Test Result yuhaliu/generate_tools_meta_support_file_path

2 tests   2 ✔️  28s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 64f9ad4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

SDK PFS E2E Test Result yuhaliu/generate_tools_meta_support_file_path

8 tests   8 ✔️  23s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 64f9ad4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

Executor Unit Test Result yuhaliu/generate_tools_meta_support_file_path

    2 files      2 suites   51s ⏱️
277 tests 276 ✔️ 1 💤 0 ❌
546 runs  543 ✔️ 3 💤 0 ❌

Results for commit 64f9ad4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

Executor E2E Test Result yuhaliu/generate_tools_meta_support_file_path

    2 files      2 suites   8m 3s ⏱️
102 tests 100 ✔️ 2 💤 0 ❌
204 runs  198 ✔️ 6 💤 0 ❌

Results for commit 64f9ad4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

SDK CLI Test Result yuhaliu/generate_tools_meta_support_file_path

    2 files      2 suites   22m 55s ⏱️
269 tests 249 ✔️ 17 💤 3 ❌
538 runs  498 ✔️ 34 💤 6 ❌

For more details on these failures, see this check.

Results for commit 5bf36a3.

♻️ This comment has been updated with latest results.

chjinche
chjinche previously approved these changes Sep 26, 2023
View reviewed changes
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 26, 2023 11:08 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 27, 2023 03:09 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 27, 2023 03:09 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 27, 2023 03:09 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 27, 2023 03:09 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 27, 2023 03:09 — with GitHub Actions Inactive
@DaweiCai DaweiCai temporarily deployed to internal September 28, 2023 05:35 — with GitHub Actions Inactive
@DaweiCai DaweiCai temporarily deployed to internal September 28, 2023 05:35 — with GitHub Actions Inactive
@DaweiCai DaweiCai temporarily deployed to internal September 28, 2023 05:35 — with GitHub Actions Inactive
@DaweiCai DaweiCai temporarily deployed to internal September 28, 2023 05:35 — with GitHub Actions Inactive
@DaweiCai DaweiCai temporarily deployed to internal September 28, 2023 05:35 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 28, 2023 08:55 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 28, 2023 08:55 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 28, 2023 08:55 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 28, 2023 08:55 — with GitHub Actions Inactive
@liuyuhang13 liuyuhang13 temporarily deployed to internal September 28, 2023 08:55 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal September 28, 2023 10:19 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal September 28, 2023 10:19 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal September 28, 2023 10:19 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal September 28, 2023 10:19 — with GitHub Actions Inactive
@chjinche chjinche temporarily deployed to internal September 28, 2023 10:19 — with GitHub Actions Inactive
@chjinche chjinche merged commit 65f8537 into main Sep 28, 2023
@chjinche chjinche deleted the yuhaliu/generate_tools_meta_support_file_path branch September 28, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chjinche chjinche chjinche approved these changes

@thy09 thy09 thy09 approved these changes

Assignees
No one assigned
Labels
promptflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuyuhang13 @thy09 @chjinche @DaweiCai