Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Verify django and jinja2 exceptions context #1181

Closed
fabioz opened this issue Feb 26, 2019 · 3 comments
Closed

Verify django and jinja2 exceptions context #1181

fabioz opened this issue Feb 26, 2019 · 3 comments
Assignees
@fabioz
Labels
Bug priority:P2 Unplanned-work
Milestone
Mar 2019.1

Comments

@fabioz
Copy link
Contributor

fabioz commented Feb 26, 2019

See: https://github.com/Microsoft/ptvsd/pull/1179/files/90dc0b17a0bceadbc0dad958be04ad5f2fa81404#diff-a3b5595e743c389ebd7b61a7ab4c3c80R131
@fabioz fabioz mentioned this issue Feb 26, 2019
Closed
@karthiknadig karthiknadig added this to the Feb 2019.2 milestone Feb 28, 2019
@karthiknadig karthiknadig changed the title Verify django exceptions context Verify django and flask exceptions context Mar 1, 2019
@karthiknadig karthiknadig changed the title Verify django and flask exceptions context Verify django and jinja2 exceptions context Mar 1, 2019
fabioz added a commit to fabioz/ptvsd that referenced this issue Mar 5, 2019
@fabioz
Fix django exception breaks. Fixes microsoft#1181
0c1b593
@fabioz fabioz closed this as completed in 9aeb125 Mar 6, 2019
@karthiknadig karthiknadig reopened this Mar 7, 2019
@karthiknadig
Copy link
Member

I am not getting a suspend event for exception break in the following cases.

Use this branch, I have the django and flask tests updated there.
https://github.com/karthiknadig/ptvsd/tree/issue694
For Django run this test:

./tests/func/test_django.py::test_django_template_exception_no_multiproc[launch]

For Flask run this test [fails on 2.7 only]:

./tests/func/test_flask.py::test_flask_template_exception_no_multiproc[launch]

@karthiknadig karthiknadig modified the milestones: Feb 2019.2, Mar 2019.1 Mar 7, 2019
@fabioz
Copy link
Contributor Author

fabioz commented Mar 8, 2019

Will take a look at it.

@fabioz fabioz self-assigned this Mar 8, 2019
@fabioz
Copy link
Contributor Author

fabioz commented Mar 11, 2019

Just to note, the problem happens when just-my-code is turned on along with django exceptions (still working on a fix).

fabioz added a commit to fabioz/ptvsd that referenced this issue Mar 15, 2019
@fabioz
Fix issues with django and jinja2 exceptions with just-my-code turned…
1760ced 
… on. Fixes microsoft#1181
fabioz added a commit to fabioz/ptvsd that referenced this issue Mar 15, 2019
@fabioz
Fix issues with django and jinja2 exceptions with just-my-code turned…
d75bfa4 
… on. Fixes microsoft#1181
@int19h int19h mentioned this issue Apr 21, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fabioz fabioz

Labels
Bug priority:P2 Unplanned-work
Projects
None yet
Milestone
Mar 2019.1
Development

No branches or pull requests
2 participants
@fabioz @karthiknadig