Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Accept new style properties for debugger options. Fixes #2001 #2005

Merged
merged 3 commits into from
Dec 25, 2019

Conversation

fabioz
Copy link
Contributor

@fabioz fabioz commented Dec 19, 2019

No description provided.

@fabioz
Copy link
Contributor Author

fabioz commented Dec 19, 2019

Please don't merge/review yet (it seems there are some tests breaking, so, I'll take a look at that...)

@int19h
Copy link
Contributor

int19h commented Dec 19, 2019

It looks like the failing tests are those that have to do with redirected output. This is probably because the adapter needs to tell pydevd to not do output redirection when the launcher is doing it, and it does so by tweaking "debugOptions" - but it doesn't adjust the property:

if self.launcher and "RedirectOutput" in debug_options:
# The launcher is doing output redirection, so we don't need the
# server to do it, as well.
arguments = dict(arguments)
arguments["debugOptions"] = list(debug_options - {"RedirectOutput"})

@fabioz fabioz requested a review from int19h as a code owner December 23, 2019 11:39
@fabioz fabioz force-pushed the ptvsd_2001_debugger_flags branch from b38058c to 7edbcdc Compare December 23, 2019 11:44
@karthiknadig karthiknadig merged commit 17d3056 into microsoft:master Dec 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants