Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove /kiosk site, redirect to /--kiosk. #6030

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Remove /kiosk site, redirect to /--kiosk. #6030

merged 3 commits into from
Aug 22, 2023

Conversation

eanders-ms
Copy link
Contributor

No description provided.

@eanders-ms eanders-ms requested a review from a team August 22, 2023 18:56
@abchatra
Copy link
Collaborator

Why is https://github.com/microsoft/pxt-arcade/blob/master/docs/kiosk.html not removed?

@eanders-ms
Copy link
Contributor Author

Why is https://github.com/microsoft/pxt-arcade/blob/master/docs/kiosk.html not removed?

thanks

srietkerk
srietkerk reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@srietkerk srietkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, just curious, though, why do we not want to get rid of the source files here in arcade?

@eanders-ms
Copy link
Contributor Author

Everything looks great, just curious, though, why do we not want to get rid of the source files here in arcade?

Scoping to just the essential changes for switch-over in case it breaks something and need to roll it back. I'll remove the old project once we know this worked.

@eanders-ms eanders-ms merged commit 7993f4d into master Aug 22, 2023
@eanders-ms eanders-ms deleted the eanders-ms/20232208-1 branch August 22, 2023 20:45
eanders-ms added a commit that referenced this pull request Oct 24, 2023
@eanders-ms
Remove /kiosk site, redirect to /--kiosk. (#6030)
01540f2 
* Remove built kiosk from docs

* Add redirect for kiosk

* Remove kiosk.html
eanders-ms added a commit that referenced this pull request Oct 24, 2023
@eanders-ms
[stable1.12] cherry-pick kiosk commits (#6152)
4d1263f 
* Add kiosk-data docs folder (#6009)

* Remove /kiosk site, redirect to /--kiosk. (#6030)

* Remove built kiosk from docs

* Add redirect for kiosk

* Remove kiosk.html

* Remove old kiosk sources (#6036)

* Move kiosk sfx to arcade repo (#6068)

* Kiosk: Run high pass filter on UI audio (#6081)

* Move kiosk game list to targetconfig.json (#6122)

* Move kiosk game list to targetconfig.json

* fix indenting

* Bump pxt-arcade-sim -> v0.11.9

* bump pxt-core -> 8.5.54

* projects.md

* Revert "Remove kiosk.html"

This reverts commit 0b1189c.

* Revert "Remove built kiosk from docs"

This reverts commit 5d52d2b.

* bump pxt-core -> 8.5.55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srietkerk srietkerk srietkerk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eanders-ms @abchatra @srietkerk