Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some link outs convert the delimiter :|: to :%7C: for being unsafe #10258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some link outs convert the delimiter :|: to :%7C: for being unsafe #10258

wants to merge 2 commits into from

Conversation

abchatra
Copy link
Collaborator

@abchatra abchatra commented Nov 3, 2024

@abchatra abchatra requested review from riknoll and thsparks November 3, 2024 03:09
riknoll
riknoll reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@riknoll riknoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it just be easier to call decodeURIComponent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riknoll riknoll riknoll left review comments

@thsparks thsparks Awaiting requested review from thsparks

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

---multi# magic URL to open two shared projects
2 participants
@abchatra @riknoll