clean up shadow blocks in insertion markers for expandable blocks #10315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srietkerk
reviewed
Dec 10, 2024
|
|
||
| // we don't know at this time whether the parent block is an insertion marker | ||
| // or not. doing this check lets us clean up the block in the case that it is, | ||
| // though we get an annoying flicker |
There was a problem hiding this comment.
I don't think it looks too bad, but I was wondering if there is any sort of css that we could also use/override to make the shadow blocks not render in the insertion marker?
There was a problem hiding this comment.
Oh, wait, is the GIF in the comment the way the insertion marker looks with the bug or how it looks with the fix for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not an ideal solution, but this fixes the insertion marker bug i mentioned in standup. here's what the bug looks like: