Skip to content

Allow keyboard to close the first Download dialog #10483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

microbit-matt-hillsdon
Copy link
Contributor

At the moment the keyboard cannot close the first "Download" flow dialog with the connect animation.

We find folks using keyboard navigation can trigger "Download" by mistake and then find it frustrating to be forced to continue through to the next dialog.

We debated whether it still made sense to force the download when bailing out at this early stage and have no strong view (this PR does).

This seemed the easiest way to suggest the change but totally open to explanation as to why the flow is structured this way. But I think something is necessary to cater for keyboard users.

@abchatra abchatra requested review from jwunderl and thsparks April 9, 2025 15:38
@thsparks
Copy link
Contributor

thsparks commented Apr 9, 2025

We removed the close button in #9486 because we found users had a gut-reaction to immediately just close the popup, then they'd get confused as to why it didn't work.

How would you feel about adding a "cancel" button at the bottom, rather than the close button at the top? The thinking being, that may not trigger the same immediate "close" reaction we saw with some users. We have this in one or two other places, like our "Reset" dialog (though in this case, I'd put cancel on the left, not the right):
image

@microbit-matt-hillsdon
Copy link
Contributor Author

How would you feel about adding a "cancel" button at the bottom, rather than the close button at the top? The thinking being, that may not trigger the same immediate "close" reaction we saw with some users. We have this in one or two other places, like our "Reset" dialog (though in this case, I'd put cancel on the left, not the right):

Yes, I think that's a good option.

@glastonbridge glastonbridge deleted the download-dialog-close-button-small branch May 22, 2025 08:44
@microbit-matt-hillsdon
Copy link
Contributor Author

Closing in favour of #10632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants