Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pointer events double trigger issue on Android #3893

Closed
wants to merge 3 commits into from

Conversation

samelhusseini
Copy link
Contributor

PR change: microsoft/pxt-blockly#98

Patch fix to fix the Android double trigger issue with pointer events conflicting with mouse events.

Note: master fix is slightly different, and is still underway (as it's based of scratch-blocks and not Blockly).

@abchatra
Copy link
Contributor

My understanding was we don't have android issue in microbit. As this issue requires iframe. Do we need this in v0?

@samelhusseini
Copy link
Contributor Author

samelhusseini commented Feb 16, 2018

The issue is that we are registering both mouse and pointer events and are "hoping" the browser links the two and prevents the other one from firing when it handles one of them.

Currently I've only seen browsers fail to link the two events on Android + iFrame, but lot's of things are changing in Chrome's pointer event handling code, that I'd rather not be at the mercy of browsers to ensure they do the right thing.

Pointer events is an extension of mouse events and there's no need to register both events if pointer events are available.

So in summary, this is somewhat precautionary, and somewhat (because its the right fix), and somewhat there might be other skews or instances where this bug portrays itself that we don't understand yet.

@abchatra
Copy link
Contributor

Lets wait for the release of microbit before merging this in. Without the repro, I would like this change to bake in.

@samelhusseini
Copy link
Contributor Author

@samelhusseini
Copy link
Contributor Author

Closing these, will create a new PR with latest fixes.

@samelhusseini samelhusseini deleted the v0_fixpointerevents branch May 16, 2018 00:50
@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants