Improve UX for cloud save #7836
Conversation
|
Pausing this as we re-evaluate priorities. |
|
Fixes: microsoft/pxt-arcade#2988 |
… can show "saving...")
…changed from invalidate() call
…before they'll funciton.
| @@ -1332,7 +1332,8 @@ export class ProjectView | |||
| // We are too late; the editor has already been loaded. | |||
| // Call the onChanges handler to update the editor. | |||
| pxt.tickEvent(`identity.syncOnProjectOpen.timedout`, { 'elapsedSec': elapsed}) | |||
| cloud.onChangesSynced(changes) | |||
| if (changes.length) | |||
| cloud.forceReloadForCloudSync() | |||
There was a problem hiding this comment.
Can this call trigger a reload while in the editor? I've seen the toast "Cloud synchronization complete. Reloading" happen in the editor, which was jarring. Logged it here: microsoft/pxt-arcade#3005
There was a problem hiding this comment.
Yes, it can. Unfortunately I don't know a good way to avoid this.
The problem is that if the user opens up a project at version A but after that we sync with the cloud and determine they should be fast-forwarded to version B, then we need to reload the editor from underneath them. Currently, there isn't a way to reload the editor's content without doing a page reload. Likely we could fix this using virtual APIs but it's another chunk of work..
| if (remote) { | ||
| local.cloudLastSyncTime = remote.cloudLastSyncTime | ||
| // Note that we use modification time to detect differences. If we had full (or partial) history, we could | ||
| // use version numbers. However we cannot currently use etags since the Cosmos list operations | ||
| // don't return etags per-version. And because of how etags work, the record itself can never | ||
| // have the latest etag version. | ||
| if (local.modificationTime !== remote.modificationTime) { | ||
| if (local.modificationTime !== remote.modificationTime || local.isDeleted !== remote.isDeleted) { |
There was a problem hiding this comment.
We need to switch to cosmos etag here. We're will see sync bugs with modificationTime.
There was a problem hiding this comment.
Yes, I'm pro switching to etags. It'll take a cloud deploy.
Yes, this is meant to be a complete PR. Future work will be in a future PR. |
* Showing more cloud state on the project cards * showing last cloud edit time and state in UX * Better date appearance; better alignment; todo lst * dynamic homescreen update works * Dim the cloud state message in the editor * Notify virtual api of header change at the start of cloud save (so we can show "saving...") * Keep cloudInProgressSyncStartTime in memory only * cloud sync update without reload is working! * update home page project list when num headers changes * Fix how delete propegates * Update virtual APIs & DataSubscriber to propegate specific path that changed from invalidate() call * Revert virtual API changes. one-to-many subscriptions need more work before they'll funciton. * Remove cloud sync message on home screen * Don't show cloud state unless saving * Keep a "saved!" indicator around right after we cloud save. * Move CloudStateSummary out of pxt localtypings * fix render bug * remove debug logging * Don't download deleted projects
* Showing more cloud state on the project cards * showing last cloud edit time and state in UX * Better date appearance; better alignment; todo lst * dynamic homescreen update works * Dim the cloud state message in the editor * Notify virtual api of header change at the start of cloud save (so we can show "saving...") * Keep cloudInProgressSyncStartTime in memory only * cloud sync update without reload is working! * update home page project list when num headers changes * Fix how delete propegates * Update virtual APIs & DataSubscriber to propegate specific path that changed from invalidate() call * Revert virtual API changes. one-to-many subscriptions need more work before they'll funciton. * Remove cloud sync message on home screen * Don't show cloud state unless saving * Keep a "saved!" indicator around right after we cloud save. * Move CloudStateSummary out of pxt localtypings * fix render bug * remove debug logging * Don't download deleted projects
Fixes: microsoft/pxt-arcade#2988
Fixes: microsoft/pxt-arcade#3017
In editor "saving..." and "saved!" message:
In project view dynamic syncing and deleting without a reload!
