Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support semantic highlighting with notebook cells #1932

Closed
roblourens opened this issue Oct 13, 2021 · 4 comments
Closed

Support semantic highlighting with notebook cells #1932

roblourens opened this issue Oct 13, 2021 · 4 comments
Labels
bug Something isn't working notebooks

Comments

@roblourens
Copy link
Member

See microsoft/vscode#129012

  • Open a jupyter notebook
  • See that semantic highlighting is not taking effect in notebook cells

I assume that this is implemented by pylance, let me know if not

@jakebailey
Copy link
Member

We provide the semantic tokens, but I'm pretty sure bugs in the notebook middleware and concat doc break things.

See also the overarching issue on microsoft/vscode-jupyter#7877 (which is very much on our radar).

@roblourens
Copy link
Member Author

Feel free to close in favor of that issue if you prefer

@jakebailey
Copy link
Member

I think the corresponding issue in the Jupyter tracker is: microsoft/vscode-jupyter#6799

(But I don't object to having a tracking issue here for people to discover.)

@heejaechang
Copy link
Contributor

this seems fixed now. it doesn't repro on latest pylance + jupyter notebook extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working notebooks
Projects
None yet
Development

No branches or pull requests

4 participants