Fixed a regression that caused an Unknown to appear in a type evalu…

…ation when using nested constructor calls. This addresses #5947.

packages/pyright-internal/src/analyzer/constructors.ts

@@ -35,6 +35,7 @@ import {
     buildTypeVarContextFromSpecializedClass,
     convertToInstance,
     doForEachSubtype,
+    ensureFunctionSignaturesAreUnique,
     getTypeVarScopeId,
     isPartlyUnknown,
     isTupleClass,
@@ -366,6 +367,14 @@ function validateNewMethod(
     let argumentErrors = false;
     const overloadsUsedForCall: FunctionType[] = [];
 
+    if (inferenceContext?.signatureTracker) {
+        newMethodTypeResult.type = ensureFunctionSignaturesAreUnique(
+            newMethodTypeResult.type,
+            inferenceContext.signatureTracker,
+            errorNode.start
+        );
+    }
+
     const typeVarContext = new TypeVarContext(getTypeVarScopeId(type));
     typeVarContext.addSolveForScope(getTypeVarScopeId(newMethodTypeResult.type));
     if (type.typeAliasInfo) {
@@ -434,6 +443,14 @@ function validateInitMethod(
     let argumentErrors = false;
     const overloadsUsedForCall: FunctionType[] = [];
 
+    if (inferenceContext?.signatureTracker) {
+        initMethodType = ensureFunctionSignaturesAreUnique(
+            initMethodType,
+            inferenceContext.signatureTracker,
+            errorNode.start
+        );
+    }
+
     // If there is an expected type, analyze the __init__ call for each of the
     // subtypes that comprise the expected type. If one or more analyzes with no
     // errors, use those results. This requires special-case processing because

packages/pyright-internal/src/tests/samples/constructor28.py

@@ -4,7 +4,7 @@
 # pyright: strict
 
 from __future__ import annotations
-from typing import Any, Callable, Generic, TypeVar, overload
+from typing import Any, Callable, Generic, Iterable, TypeVar, overload
 
 T = TypeVar("T")
 S = TypeVar("S", covariant=True)
@@ -76,3 +76,7 @@ def __call__(self, obj: Any) -> Any:
 
 
 func3(ClassD(""), ClassD(""))
+
+
+def func4(a: Iterable[tuple[str, ...]]):
+    zip(a, zip(*a))