Changed pythonPlatform to accept a value of "All" in which case no pa…

…rticular platform will be used over the others.
microsoft · Jan 4, 2021 · 602aefa · 602aefa
1 parent 2fd7846
commit 602aefa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/pyright-internal/src/analyzer/staticExpressions.ts b/packages/pyright-internal/src/analyzer/staticExpressions.ts
@@ -69,7 +69,7 @@ export function evaluateStaticBoolExpression(
             // Handle the special case of "sys.platform != 'X'"
             const comparisonPlatform = node.rightExpression.strings.map((s) => s.value).join('');
             const expectedPlatformName = _getExpectedPlatformNameFromPlatform(execEnv);
-            return _evaluateStringBinaryOperation(node.operator, expectedPlatformName || '', comparisonPlatform);
+            return _evaluateStringBinaryOperation(node.operator, expectedPlatformName, comparisonPlatform);
         } else if (
             _isOsNameInfoExpression(node.leftExpression) &&
             node.rightExpression.nodeType === ParseNodeType.StringList

diff --git a/packages/vscode-pyright/schemas/pyrightconfig.schema.json b/packages/vscode-pyright/schemas/pyrightconfig.schema.json
@@ -423,7 +423,7 @@
       "examples": [
         "Linux"
       ],
-      "pattern": "^(Linux|Windows|Darwin)$"
+      "pattern": "^(Linux|Windows|Darwin|All)$"
     },
     "venvPath": {
       "$id": "#/properties/venvPath",
@@ -497,7 +497,7 @@
             "examples": [
               "Linux"
             ],
-            "pattern": "^(Linux|Windows|Darwin)$"
+            "pattern": "^(Linux|Windows|Darwin|All)$"
           },
           "venv": {
             "$id": "#/properties/venv",