Fix realCasePath changing empty paths to . #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Sep 21, 2023
| @@ -536,7 +536,7 @@ export function stripFileExtension(fileName: string, multiDotExtension = false) | |||
| } | |||
|
|
|||
| export function realCasePath(pathString: string, fileSystem: ReadOnlyFileSystem): string { | |||
| return normalizePath(fileSystem.realCasePath(pathString)); | |||
There was a problem hiding this comment.
This normalizePath can change the empty string into a .. We shouldn't need to normalize since calling real case o n a path will have that same effect anyway.
debonte
approved these changes
Sep 21, 2023
This comment has been minimized.
This comment has been minimized.
erictraut
approved these changes
Sep 21, 2023
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses microsoft/pylance-release#4861
The root cause of this bug is that for a loose file (no workspace), the current execution root for command line options is just ''. Normalizing this changes it to '.' for some reason and that breaks all the other logic after that point.
The fix here is to not normalize when calling realCasePath. Nodefs.realCase can normalize paths on its own, so it's not necessary to normalize them ahead of time.