Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs could be clearer about which .pth files work in editable install scenarios #6079

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

debonte
Copy link
Collaborator

@debonte debonte commented Oct 3, 2023

Addresses microsoft/pylance-release#4855

The current documentation around editable installs tells users to use .pth files instead of import hooks. A user recently pointed out that this language is confusing because installing an import hook requires a .pth file. So, the existence of a .pth file doesn't indicate that an editable install is Pyright-friendly.

The first commit updates the language.
The second commit re-justifies the text to match the rest of the file.

@debonte debonte requested a review from erictraut October 3, 2023 23:11
@debonte debonte merged commit 4137f0c into microsoft:main Oct 3, 2023
@debonte debonte deleted the pylance4855 branch October 3, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants