Skip keyword-only params with invalid names in signature help #9398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
erictraut
reviewed
Nov 6, 2024
packages/pyright-internal/src/languageService/signatureHelpProvider.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
erictraut
reviewed
Nov 7, 2024
packages/pyright-internal/src/languageService/signatureHelpProvider.ts
Outdated
Show resolved
Hide resolved
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
erictraut
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the signature help provider to handle the scenarios mentioned in #9386. Signature help should not suggest to the user that they can use a kwarg to initialize the value of a dataclass field with an alias that is not a valid identifier.
I think showing position-only parameters with invalid names is fine. And position-or-keyword parameters are also ok to show given that the completion provider was already updated to not suggest these param names.