Fixed bug that causes a false positive overlapping overload error whe… #9516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the overload accepts a `Callable[..., T]` form. This addresses #9514.
|
Diff from mypy_primer, showing the effect of this PR on open source code: hydra-zen (https://github.com/mit-ll-responsible-ai/hydra-zen)
+ /tmp/mypy_primer/projects/hydra-zen/src/hydra_zen/typing/_builds_overloads.py:293:38 - error: Unnecessary "# pyright: ignore" rule: "reportOverlappingOverload" (reportUnnecessaryTypeIgnoreComment)
- 176 errors, 15 warnings, 183 informations
+ 177 errors, 15 warnings, 183 informations
scrapy (https://github.com/scrapy/scrapy)
- /tmp/mypy_primer/projects/scrapy/scrapy/utils/defer.py:82:5 - error: Overload 2 for "mustbe_deferred" will never be used because its parameters overlap overload 1 (reportOverlappingOverload)
- /tmp/mypy_primer/projects/scrapy/scrapy/utils/defer.py:90:5 - error: Overload 3 for "mustbe_deferred" will never be used because its parameters overlap overload 1 (reportOverlappingOverload)
- 2126 errors, 122 warnings, 0 informations
+ 2124 errors, 122 warnings, 0 informations
pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ /tmp/mypy_primer/projects/pandas-stubs/pandas-stubs/core/groupby/generic.pyi:214:115 - error: Unnecessary "# pyright: ignore" rule: "reportOverlappingOverload" (reportUnnecessaryTypeIgnoreComment)
- 1552 errors, 0 warnings, 0 informations
+ 1553 errors, 0 warnings, 0 informations
mypy (https://github.com/python/mypy)
- /tmp/mypy_primer/projects/mypy/mypy/typeshed/stdlib/inspect.pyi:208:5 - error: Overload 1 for "isgeneratorfunction" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
- /tmp/mypy_primer/projects/mypy/mypy/typeshed/stdlib/inspect.pyi:214:5 - error: Overload 1 for "iscoroutinefunction" overlaps overload 3 and returns an incompatible type (reportOverlappingOverload)
- /tmp/mypy_primer/projects/mypy/mypy/typeshed/stdlib/inspect.pyi:225:5 - error: Overload 1 for "isasyncgenfunction" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
- /tmp/mypy_primer/projects/mypy/mypy/typeshed/stdlib/asyncio/coroutines.pyi:19:5 - error: Overload 1 for "iscoroutinefunction" overlaps overload 3 and returns an incompatible type (reportOverlappingOverload)
- 1751 errors, 108 warnings, 0 informations
+ 1747 errors, 108 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n the overload accepts a
Callable[..., T]form. This addresses #9514.