Added check for importing a Final variable from another module and …
#9532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…then attempting to overwrite it. This partially addresses microsoft/pylance-release#6455. Added check for an attempt to assign to a module-local variable if it is shadowing a `Final` variable declared by the builtins module or some other chained file. This addresses microsoft/pylance-release#6455.
|
Diff from mypy_primer, showing the effect of this PR on open source code: rotki (https://github.com/rotki/rotki)
+ /tmp/mypy_primer/projects/rotki/rotkehlchen/tests/fixtures/__init__.py
+ /tmp/mypy_primer/projects/rotki/rotkehlchen/tests/fixtures/__init__.py:4:6 - error: "USERSDIR_NAME" is declared as Final and cannot be reassigned (reportGeneralTypeIssues)
- 3437 errors, 265 warnings, 0 informations
+ 3438 errors, 265 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…then attempting to overwrite it. This partially addresses microsoft/pylance-release#6455.
Added check for an attempt to assign to a module-local variable if it is shadowing a
Finalvariable declared by the builtins module or some other chained file. This addresses microsoft/pylance-release#6455.