Pull Pylance with Pyright 1.1.390 #9543
Open
+75
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
the modules from pylance is not working even though the required module is downloaded |
jamierpond
reviewed
Dec 12, 2024
Comment on lines
+22
to
+24
| // Use a magic comment to prevent webpack from creating an extra chunk for the dynamic import by default. | ||
| // An extra chunk will still be created if explicitly configured in the webpack config. | ||
| TOML = await import(/* webpackMode: "eager" */ 'smol-toml'); |
There was a problem hiding this comment.
This phrasing is slightly confusing, it could almost be read like it's an instruction and not the addition that you've made when viewed outside the scope of this PR?
Maybe explain more about why the comment works, since that does seem magic or like it shouldn't work lol, maybe a link to the associated documentation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.