Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upper bounds don't work on python_requires #15

Closed
zooba opened this issue Mar 29, 2022 · 1 comment · Fixed by #20
Closed

Upper bounds don't work on python_requires #15

zooba opened this issue Mar 29, 2022 · 1 comment · Fixed by #20
Assignees
@dciborow

Comments

@zooba
Copy link
Member

zooba commented Mar 29, 2022

python-package-template/setup.py

Line 61 in 1fb2c18

python_requires=">=3.7,<3.8",

Full discussion at https://discuss.python.org/t/requires-python-upper-limits/12663, but basically it was added to provide a programmatic way to let pip find earlier versions of a package to support earlier versions of Python. Older versions of a package generally can't support newer versions of Python than the newest package, so an upper bound isn't even checked.
@dciborow dciborow linked a pull request Apr 14, 2022 that will close this issue
Create pyproject.toml #20
Merged
@dciborow
Copy link
Contributor

Will address this as I update from setup.py to pyproject.toml.

@dciborow dciborow self-assigned this Apr 14, 2022
isaac-cf-wong added a commit to isaac-cf-wong/python-package-template that referenced this issue Jan 29, 2025
@isaac-cf-wong
Merge pull request microsoft#15 from isaac-cf-wong/dependabot/pip/pre…
0d8b39d 
…-commit-4.1.0

fix: bump pre-commit from 3.3.1 to 4.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dciborow dciborow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create pyproject.toml microsoft/python-package-template
2 participants
@zooba @dciborow