- 
                Notifications
    You must be signed in to change notification settings 
- Fork 152
Add images to Deutsch algorithm kata #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Benchmark for e9bd145Click to view benchmark
 | 
| I redrew images compared to what we have in the classic katas (to remove column vectors and only use ket notations), and that sped up image load significantly compared to the old images - I don't see a noticeable delay in kata load now | 
| I haven't heard anything about themes support in the katas (personally I don't use dark themes outside of console, since they hurt my eyes). This image is based on the "official" one provided by our designer team (same style, different notations), so I guess we don't have themes at the moment. I'm happy to accept optimization suggestions, as long as they come with specific commands to do them that can be easily followed by non-designers :-) These images, I got by saving PowerPoint diagram in svg and then scaling them using Figma, and they're a lot smaller than the previous iteration with column vectors, so I'm happy with them. I don't anticipate having more than 5-ish images per kata, and that's only for Grover, most are going to be image-free, so I hope it won't be a problem. | 
| We discussed offline and decided to go ahead with these images as a pilot, unoptimized, and see what the performance looks like on the website. We'll also discuss themes with the website team, whether this is something we want to support. | 
Co-Authored-By: Bill Ticehurst <billti@microsoft.com>
Using Inkscape to save them as "optimized SVGs"
f03c793    to
    7ef6731      
    Compare
  
    | I used Inkscape to optimize the images automatically, so the three of them are ~68k now. | 
| Benchmark for 592d3dfClick to view benchmark
 | 


This closes #1156.