Skip to content

Adding Measurements tasks 2.2-2.3 to Distinguishing States #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2024
Merged

Adding Measurements tasks 2.2-2.3 to Distinguishing States #1615

merged 3 commits into from
Jun 6, 2024

Conversation

@JPark1023
Copy link
Contributor

Resolves part of #1185

tcNickolas
tcNickolas approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though the last task, I'll admit, was done long enough ago that I don't remember the nuances of the solution... I left a fair number of comments on formatting, I should be able to apply all of them as suggestions before merging.

Thank you!

@tcNickolas tcNickolas enabled auto-merge June 6, 2024 21:11
@tcNickolas tcNickolas added this pull request to the merge queue Jun 6, 2024
Merged via the queue into microsoft:main with commit f2b6e7b Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billti billti Awaiting requested review from billti billti is a code owner

@cesarzc cesarzc Awaiting requested review from cesarzc

@DmitryVasilevsky DmitryVasilevsky Awaiting requested review from DmitryVasilevsky DmitryVasilevsky is a code owner

@sezna sezna Awaiting requested review from sezna

@swernli swernli Awaiting requested review from swernli swernli is a code owner

1 more reviewer

@tcNickolas tcNickolas tcNickolas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JPark1023 @tcNickolas